feat: add get3DModels api for arm client #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DTCurrie
approved these changes
Nov 6, 2025
stuqdog
reviewed
Nov 10, 2025
Member
stuqdog
left a comment
stuqdog
left a comment
There was a problem hiding this comment.
Core logic seems totally reasonable to me! though I think we should probably revert the api_version.lock change.
Member
There was a problem hiding this comment.
This file is auto-updated when we run the update_protos workflow and probably shouldn't be touched by hand. Can I ask why you chose to update it?
Member
Author
There was a problem hiding this comment.
I created a new common type Get3DModelsRequest that would not get generated without the newer api version
Member
Author
There was a problem hiding this comment.
Update: now that the version has been bumped in main, I just pulled in those changes so I do not have the api_version change in this PR anymore
stuqdog
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the Get3DModels api for the ts-sdk as outlined in this approved scope doc https://docs.google.com/document/d/1jOQYh6OAsK09GhXWCqigGT739apX96RFcmTtFvyVMnE/edit?tab=t.0#heading=h.xxey084ghl07
Testing